• 0 Posts
  • 14 Comments
Joined 11 months ago
cake
Cake day: November 20th, 2024

help-circle

  • Yes, the DE-specific implementations is pointless (as far as I know, I use a WM), but the XDG implementation is actually used first, and the function returns true if any impl returns true, like xdg() || gnome() || gnome_old() || kde().

    True, I must’ve read the code wrong when making the comment.

    This isn’t that bad?

    Yes, which is why I take issue with a PR (or rather what should have been a PR) that introduces crap code with clearly visible low effort improvements - the submitter should’ve already done that so the project doesn’t unnecessarily gain technical debt by accepting the change.

    With multiple impls, you have to resolve conflicts somehow.

    Yep, that’s why I think it’s important for the implementations to actually differentiate between light and fail state - that’s the smallest change and allows you to keep the whole detection logic in the individual implementations. Combine that with XDG being the default/first one and you get something reasonable (in a world where the separate implementations are necessary). You do mention this, but I feel like the whole two paragraphs are just expanding on this idea.

    But it’s better to criticize the code’s actual faults (…)

    I made a mistake with the order in which the implementations are called, but I consider the rest of the comment to still stand and the criticisms to be valid.


  • Well, the detection is broken for KDE and backwards in the XDG implementation (which is also only used as a fallback when the three DE-specific implementations fail, even though all of them actually support XDG so having separate implementations is pointless).

    Also with the way it’s implemented, it will have unexpected results for users who have both KDE and Gnome installed (or at least have leftover configuration files) - if you for example used KDE in the past with a theme considered to be “dark” by this and now use Gnome and have it set to light mode, you will get dark mode GZdoom with no obvious reason why.

    Oh and the XDG implementation is also very fragile and will not work on everyone’s system because it depends on a specific terminal utility being installed. The proper way would be to use a DBus library and get the settings through that.

    And when somebody comes to fix it, they will have to figure out a) what’s so special about the DE-specific implementations that XDG wasn’t enough (they might just assume that XDG isn’t supported widely enough), b) learn how to detect dark theme properly on the DE they’re fixing, c) rework the code so that there is a difference between “this DE wants light mode” and “couldn’t figure out of this DE is in light or dark mode” - both of these are now represented by the “false” return value.

    I don’t think a well written and functioning code made with AI assistance would get a response this strong, but the problem here is that the code is objectively bad and its (co-)author kept doubling down about something they probably barely even checked.


  • Don’t know about the UK, but in central Europe it’s common for houses to get three phase power that can then be used on 400V three phase circuits and gets split (ideally evenly) into 240V circuits. And the fact that the phases have effectively zero coupling means that you also need to just try the adapter to find out if it’s going to work or not unless you happen to know how exactly your house is wired up, just like with split phase power.

    Apartments usually get a single phase though, but IMHO it’s also less likely that WiFi won’t be enough there, so it’s questionable if that’s even a point for powerline.


  • Markaos@discuss.tchncs.detoTechnology@lemmy.ml00000
    link
    fedilink
    arrow-up
    1
    ·
    edit-2
    2 months ago

    Just to be clear, the applets were stuck while the laptop was plugged in? If so, then it might just be the threshold - connected, not charging, not discharging (because the laptop is running off the AC adapter).

    For example on my IdeaPad laptop, when I enable the charge limiting feature it will get “stuck” at 59 or 60% while plugged in. It doesn’t have a configurable threshold. Although your laptop might provide a more fine-grained control given that you were able to fully discharge it while plugged in.






  • Sure, but I don’t see how any of that disproves the current “M$ supremacy” for “normies” - the fact is that people who couldn’t care less about how their computers work will have a much easier time using Windows (and probably macOS) than any Linux distro. You don’t have to worry that some software won’t be available to you because of your choice of the OS, and if you ever have a problem it’s easy to find help.

    I haven’t used Windows in a decade on my personal computers, but as long as these two things hold true, it will always be my recommended OS for people who simply don’t care - I’m not going to spend my time doing free IT support for everyone I know and then get blamed everytime something doesn’t work.





  • Please don’t pretend as if OpenSource Devs don’t constantly complain about pesky PRs😅

    <i>I</i>'ve <u>seen</u> much <b><u>more</u> complaints</b> about <a href=“https://0.0.0.0/random_img.tiff”>people</a> constantly <marquee>demanding</marquee> their specific <h1>annoyances</h1> to be fixed without ever <i>submitting <u>a single <b>line of code</b></u></i>. <i>Maintainers</i> are pretty much <b>universally</b> welcoming to code <h2>contributions</h2> <br><br><br><br><br><br>

    I soooo hope this does something funky with someone’s Lemmy client